[
https://issues.apache.org/jira/browse/MJAVADOC-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923102#comment-17923102
]
ASF GitHub Bot commented on MJAVADOC-826:
-----------------------------------------
oehme opened a new pull request, #358:
URL: https://github.com/apache/maven-javadoc-plugin/pull/358
The aggregate javadoc mojo was calling `addAll` directly on the list
returned by `project.getCompileSourceRoots`. This bug was silently ignored by
Maven 3, but results in an `UnsupportedOperationException` on Maven 4.
Do a defensive copy instead.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A
more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Aggregate mojo broken on Maven 4
> --------------------------------
>
> Key: MJAVADOC-826
> URL: https://issues.apache.org/jira/browse/MJAVADOC-826
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Reporter: Stefan Oehme
> Priority: Major
>
> On Maven 4, the aggregate plugin fails with
> {code:java}
> Caused by: java.lang.UnsupportedOperationException
> at java.util.ImmutableCollections.uoe(ImmutableCollections.java:142)
> at
> java.util.ImmutableCollections$AbstractImmutableCollection.addAll(ImmutableCollections.java:148)
> at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.getSourcePaths(AbstractJavadocMojo.java:2207)
> {code}
> This is because it tries to modify the project's sourceRoots instead of
> making a copy first.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
