gnodet commented on PR #21:
URL: 
https://github.com/apache/maven-xinclude-extension/pull/21#issuecomment-2611782201

   > #20
   > 
   > This new test should pass but fails. The included document should not 
necessarily assume that its default namespace is the same as the document it's 
being merged into.
   
   A code style fix would be welcome to actually show that the test fail.
   However, I do think the test is wrong.  There's a subtle difference between 
having no namespace specified (i.e. an element being in the default namespace), 
and an element with a `xmlns=""` specified.
   
   For example, if you change the disclaimer to be:
   ```
   <disclaimer xmlns="">
     <p>The opinions represented herein represent those of the individual
     and should not be interpreted as official policy endorsed by this
     organization.</p>
   </disclaimer>
   ```
   then the test suddenly works.
   
   So if the included element has no namespace specified, it does inherit the 
one from the including document.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to