[ 
https://issues.apache.org/jira/browse/MNG-8527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916514#comment-17916514
 ] 

Anders Hammar commented on MNG-8527:
------------------------------------

What happens in 4.0.0-rc-2 is that I can use the new Maven 4 features in a 
model 4.0.0 pom without Maven complaining. So when the build pom is published 
it might not be a valid pom for consumers.
For example, you cna use the 'bom' packaging and the published pom will then 
keep that packaging instead of transforming to 'pom'. You can also remove the 
modelVersion element. Etc.

If a proper consumer pom isn't generated, Maven 4 should fail on a model 
version 4.0.0 pom that is using 4.1.0 features.

> Re-enable consumer POM
> ----------------------
>
>                 Key: MNG-8527
>                 URL: https://issues.apache.org/jira/browse/MNG-8527
>             Project: Maven
>          Issue Type: Task
>    Affects Versions: 4.0.0-rc-2
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>            Priority: Major
>             Fix For: 4.0.0-rc-3
>
>
> The consumer POM has been disabled in RC-2 (see MNG-8393) for 4.0.0 models.
> I think it needs to be enabled again.
> But there are a few things to fix:
> * some properties (including CI-friendly) may leak through from consumer to 
> dependency POM (see MNG-8523)
> * the consumer pom flattens and inline all properties, which may be a problem 
> if the property can be modified by a profile (javafx use case)
> * the flattening process also makes all poms much more heavy as they usually 
> convey lots of (previously inherited) data such as managed dependencies.
> For the leak, this happens if the property is not actually defined as a 
> property in the pom.  It may come from a Maven user property.  In such case, 
> the property value won't be in the installed POM (when not using consumer 
> POM), which means it can be modified by a user property from the requesting 
> POM.
> This is also related to profile activation, which may be activated or 
> deactivated using user  or system properties (including OS data which can be 
> overridden from CLI).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to