[ 
https://issues.apache.org/jira/browse/MNG-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914172#comment-17914172
 ] 

Guillaume Nodet commented on MNG-8523:
--------------------------------------

Example of leaking:
{code}
➜  tmp mvn eu.maveniverse.maven.plugins:toolbox:gav-tree 
-Dgav=org.openjfx:javafx-controls:22.0.1  -Dos.name=windows -Dos.arch=amd64 -V 
-Djavafx.monocle=true
Apache Maven 4.0.0-rc-2 (273314404f85ec3c089e295d8b4e0cb18c287cf5)
Maven home: /Users/gnodet/work/apps/apache-maven-4.0.0-rc-2
Java version: 21.0.4, vendor: Eclipse Adoptium, runtime: 
/Users/gnodet/.sdkman/candidates/java/21.0.4-tem
Default locale: en_FR, platform encoding: UTF-8
OS name: "mac os x", version: "15.2", arch: "aarch64", family: "mac"
[INFO]
[INFO] Some problems were encountered while building the effective settings 
(use -X to see details)
[INFO]
[INFO] Mimir 0.2.3 session created
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------------------------------< 
org.apache.maven:standalone-pom >--------------------------------------------
[INFO] Building Maven Stub Project (No POM) 1
[INFO] ---------------------------------------------------------[ pom 
]----------------------------------------------------------
[INFO]
[INFO] --- toolbox:0.6.1:gav-tree (default-cli) @ standalone-pom ---
[WARNING] 6 problems were encountered while building the effective model for 
org.openjfx:javafx-controls:jar:22.0.1 during n/a (use -X to see details)
[INFO] org.openjfx:javafx-controls:jar:22.0.1
[INFO] ├─org.openjfx:javafx-controls:jar:win-monocle:22.0.1 [compile]
[INFO] ╰─org.openjfx:javafx-graphics:jar:22.0.1 [compile]
[INFO]   ├─org.openjfx:javafx-graphics:jar:win-monocle:22.0.1 [compile]
[INFO]   ╰─org.openjfx:javafx-base:jar:22.0.1 [compile]
[INFO]     ╰─org.openjfx:javafx-base:jar:win-monocle:22.0.1 [compile]
[INFO] 
--------------------------------------------------------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] 
--------------------------------------------------------------------------------------------------------------------------
[INFO] Total time:  0.270 s
[INFO] Finished at: 2025-01-17T17:27:04+01:00
[INFO] 
--------------------------------------------------------------------------------------------------------------------------
{code}

In this case, the {{javafx.monocle=true}} user property leaks to the dependency 
and causes the {{org.openjfx:javafx-controls:jar:win-monocle:22.0.1}} artifact 
to be included.

The {{os.name}} and {{os.arch}} user properties also leak to activate a 
specific profile. I'm not sure this is a bad thing in this case, but this may 
need to be controlled more tightly.

> CI Friendly versions are not inlined
> ------------------------------------
>
>                 Key: MNG-8523
>                 URL: https://issues.apache.org/jira/browse/MNG-8523
>             Project: Maven
>          Issue Type: Bug
>            Reporter: Tamas Cservenak
>            Priority: Major
>             Fix For: 4.0.0-rc-3
>
>
> The installed/deployed POMs using these are not inlined, and that means those 
> are unusable. Same situation as with Maven 3, that forces use of flatten 
> plugin to make them usable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to