roadSurfer commented on code in PR #297:
URL: https://github.com/apache/maven-enforcer/pull/297#discussion_r1915119276


##########
enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesDontExist.java:
##########
@@ -107,15 +106,58 @@ void testEmptyFileListAllowNull() {
     @Test
     void testFileDoesNotExist() throws EnforcerRuleException, IOException {

Review Comment:
   Please give me a format of the new method name you'd prefer and I will 
ensure that all `test...Exists` and `test...DoesNotExist` methods are updated 
in all test classes.
   Such a change will affect `TestRequireFilesSize`, `TestRequireFileChecksum` 
`TestRequireFilesDontExist`, and `TestRequireFilesExist`; this means touching 
classes that are unrelated to the bug fix in order to ensure naming consistency.
   
   To be clear, I disagree with this but it is not my project and so I will 
follow your direction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to