gnodet commented on code in PR #2042:
URL: https://github.com/apache/maven/pull/2042#discussion_r1913105272
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/MavenSimpleConfiguration.java:
##########
@@ -37,7 +40,16 @@ public void setRootLoggerLevel(Level level) {
case INFO -> "info";
default -> "error";
};
- System.setProperty("org.slf4j.simpleLogger.defaultLogLevel", value);
+
+ String defaultLogLevelKey = "org.slf4j.simpleLogger.defaultLogLevel";
+ String current = System.getProperty(defaultLogLevelKey);
+ if (current == null) {
+ System.setProperty(defaultLogLevelKey, value);
+ } else {
+ LOGGER.warn(
+ "org.slf4j.simpleLogger.defaultLogLevel already set to:
{},ignore -X/-e/-q command line options",
Review Comment:
Maybe rephrase as:
```
LOGGER.warn(
"System property '{}' is already set to '{}' - ignoring log level
from -X/-e/-q options",
defaultLogLevelKey,
current);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
