elharo commented on code in PR #128: URL: https://github.com/apache/maven-gh-actions-shared/pull/128#discussion_r1912187359
########## README.md: ########## @@ -193,12 +199,18 @@ to update labels, milestones of PR from forked repositories. After approval or merged: - default label - `maintenance` will be added - current milestone will be set - -## More options -More options with default values can be found in workflow source in `inputs` section: +## milestone configuration -https://github.com/apache/maven-gh-actions-shared/blob/v4/.github/workflows/maven-verify.yml +We need exactly **one** opened milestone in order to detect which is current. + +In case when we need more than one opened mielestone, we have add to milestone description: Review Comment: If we need more than one open milestone, we have to add a branch to the milestone description ########## README.md: ########## @@ -193,12 +199,18 @@ to update labels, milestones of PR from forked repositories. After approval or merged: - default label - `maintenance` will be added - current milestone will be set - -## More options -More options with default values can be found in workflow source in `inputs` section: +## milestone configuration -https://github.com/apache/maven-gh-actions-shared/blob/v4/.github/workflows/maven-verify.yml +We need exactly **one** opened milestone in order to detect which is current. + +In case when we need more than one opened mielestone, we have add to milestone description: + +``` +branch: <branch name> +``` + +to point which one is default for specific branch. Review Comment: This identifies the default for that branch. ########## README.md: ########## @@ -193,12 +199,18 @@ to update labels, milestones of PR from forked repositories. After approval or merged: - default label - `maintenance` will be added - current milestone will be set - -## More options -More options with default values can be found in workflow source in `inputs` section: +## milestone configuration -https://github.com/apache/maven-gh-actions-shared/blob/v4/.github/workflows/maven-verify.yml +We need exactly **one** opened milestone in order to detect which is current. Review Comment: opened --> open -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
