gnodet commented on code in PR #2018:
URL: https://github.com/apache/maven/pull/2018#discussion_r1909962400
##########
src/mdo/model-v3.vm:
##########
@@ -189,10 +189,10 @@ public class ${class.name}
public void set${cap}(${type} ${field.name}) {
#if ($field.type == "DOM")
- if (${field.name} instanceof Xpp3Dom) {
- if (!Objects.equals(((Xpp3Dom) ${field.name}).getDom(),
getDelegate().${pfx}${cap}())) {
- update(getDelegate().with${cap}(((Xpp3Dom)
${field.name}).getDom()));
- ((Xpp3Dom) ${field.name}).setChildrenTracking(this::replace);
+ if (${field.name} instanceof Xpp3Dom xpp3DomFieldName) {
Review Comment:
`xpp3DomFieldName` name is wrong here.
I don't see any loop around, so maybe simply `xpp3dom` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
