slachiewicz commented on code in PR #135: URL: https://github.com/apache/maven-wagon/pull/135#discussion_r1899649598
########## wagon-providers/pom.xml: ########## @@ -52,24 +51,11 @@ under the License. <artifactId>httpclient</artifactId> <version>4.5.14</version> </dependency> - <!-- Overwrite transitive dependency version of HttpClient --> - <dependency> - <groupId>commons-codec</groupId> - <artifactId>commons-codec</artifactId> - <version>1.16.1</version> - <scope>runtime</scope> - </dependency> <dependency> <groupId>org.apache.httpcomponents</groupId> <artifactId>httpcore</artifactId> <version>4.4.16</version> </dependency> - <dependency> - <groupId>org.apache.sshd</groupId> - <artifactId>sshd-core</artifactId> - <version>0.8.0</version> - <scope>test</scope> - </dependency> Review Comment: It is required but only in one wagon-providers/wagon-ssh-common-test specific module here https://github.com/apache/maven-wagon/pull/135/files/72c1253cbac6240af6290ef01b40a8027a78f8a3#diff-15f3b17854f455ff3800ee2b45fa961a70bae1876256de66dc9bcd06bc19e1b3R58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org