[ 
https://issues.apache.org/jira/browse/MNG-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907712#comment-17907712
 ] 

Matthias Bünger edited comment on MNG-8431 at 12/22/24 8:11 PM:
----------------------------------------------------------------

I tried to figure out if this page can be fixed, but I think it's not possible 
as of now.
{code}
org.apache.maven.lifecycle.DefaultLifecycles.java
{code}

has a public array which default lifecycles exists ({{STANDARD_LIFECYCLES}}) 
(which is btw. not used but its content duplicated in the Mapper 
{code}DefaultLifecycleMapping String[] lifecycleIds = {"default", "clean", 
"site"};{code}. But I saw your TODO comment to provide an external 
configuration.

However the definition which phases are bound to a lifecycle are in **inner** 
classes of {{DefaultLifecycleRegistry.java}}, each with a public method 
{code}{public Collection<Phase> phases()} .{code}

The phases in thoses collections, reference to the new interface {Lifecycle} in 
the api-package.

However, in Maven site project, we have the guide about lifecycles which lists 
the phases - 
https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html

So my suggestion is to just delete the "lifecycles.html" in Maven core and keep 
the site's one up to date (needs a Maven 4 update anyway due the changes to 
lifecycle - there's not issue to do so yet. I didn't created it now, as I 
wanted to wait for your feedback on this one)


was (Author: JIRAUSER302100):
I tried to figure out if this page can be fixed, but I think it's not possible 
as of now.
{code}
org.apache.maven.lifecycle.DefaultLifecycles.java
{code}

has a public array which default lifecycles exists ({STANDARD_LIFECYCLES}) 
(which is btw. not used but its content duplicated in the Mapper 
{code}DefaultLifecycleMapping String[] lifecycleIds = {"default", "clean", 
"site"};{code}. But I saw your TODO comment to provide an external 
configuration.

However the definition which phases are bound to a lifecycle are in **inner** 
classes of {DefaultLifecycleRegistry.java}, each with a public method 
{code}{public Collection<Phase> phases()} .{code}

The phases in thoses collections, reference to the new interface {Lifecycle} in 
the api-package.

However, in Maven site project, we have the guide about lifecycles which lists 
the phases - 
https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html

So my suggestion is to just delete the "lifecycles.html" in Maven core and keep 
the site's one up to date (needs a Maven 4 update anyway due the changes to 
lifecycle - there's not issue to do so yet. I didn't created it now, as I 
wanted to wait for your feedback on this one)

> Lifecycle doc broken
> --------------------
>
>                 Key: MNG-8431
>                 URL: https://issues.apache.org/jira/browse/MNG-8431
>             Project: Maven
>          Issue Type: Bug
>            Reporter: Guillaume Nodet
>            Priority: Major
>             Fix For: 4.0.0-rc-3
>
>
> https://maven.apache.org/ref/4-LATEST/maven-core/lifecycles.html#default-lifecycle
> which points to
> https://github.com/apache/maven/blob/13ad6376e00aa5eb28f41a84e0dd06bb1f045c2e/impl/maven-core/src/site/apt/lifecycles.apt.vm



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to