elharo commented on code in PR #72:
URL:
https://github.com/apache/maven-remote-resources-plugin/pull/72#discussion_r1891825699
##########
src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java:
##########
@@ -918,16 +906,12 @@ protected void processResourceBundles(ClassLoader
classLoader, VelocityContext c
if (!copyResourceIfExists(f, projectResource, context)) {
if (doVelocity) {
try (CachingOutputStream os = new
CachingOutputStream(f)) {
- try (Writer writer = bundle.getSourceEncoding() ==
null
- ? new OutputStreamWriter(os)
- : new OutputStreamWriter(os,
bundle.getSourceEncoding())) {
- if (bundle.getSourceEncoding() == null) {
- // TODO: Is this correct? Shouldn't we
behave like the rest of maven and fail
- // down to JVM default instead ISO-8859-1 ?
- velocity.mergeTemplate(bundleResource,
"ISO-8859-1", context, writer);
- } else {
- velocity.mergeTemplate(bundleResource,
bundle.getSourceEncoding(), context, writer);
- }
+ String bundleEncodeing =
bundle.getSourceEncoding();
Review Comment:
bundleEncoding
##########
src/main/java/org/apache/maven/plugin/resources/remote/BundleRemoteResourcesMojo.java:
##########
@@ -94,9 +94,9 @@ public void execute() throws MojoExecutionException {
}
if (sourceEncoding == null || sourceEncoding.isEmpty()) {
- getLog().warn("sourceEncoding has not been set, using platform
encoding " + ReaderFactory.FILE_ENCODING
+ getLog().warn("sourceEncoding has not been set, using platform
encoding " + Charset.defaultCharset()
Review Comment:
commas should be semicolons
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
