[
https://issues.apache.org/jira/browse/MRRESOURCES-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906872#comment-17906872
]
ASF GitHub Bot commented on MRRESOURCES-150:
--------------------------------------------
slawekjaranowski commented on code in PR #69:
URL:
https://github.com/apache/maven-remote-resources-plugin/pull/69#discussion_r1890939510
##########
pom.xml:
##########
@@ -211,6 +211,12 @@ under the License.
<version>${mavenVersion}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest-library</artifactId>
+ <version>1.3</version>
Review Comment:
There is a 3.0 version
https://hamcrest.org/JavaHamcrest/distributables
> Ensure reproducible order in bundle
> -----------------------------------
>
> Key: MRRESOURCES-150
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-150
> Project: Maven Remote Resources Plugin
> Issue Type: Improvement
> Reporter: Attila Doroszlai
> Assignee: Slawomir Jaranowski
> Priority: Major
> Fix For: next-release
>
>
> {{remote-resources:bundle}} creates output that may not be reproducible.
> {code:title=https://github.com/apache/maven-remote-resources-plugin/blob/7a40047813a7cfde0a1bfeedff66bdc76f7ea430/src/main/java/org/apache/maven/plugin/resources/remote/BundleRemoteResourcesMojo.java#L108-L122}
> DirectoryScanner scanner = new DirectoryScanner();
> scanner.setBasedir(resourcesDirectory);
> if (includes != null && includes.length != 0) {
> scanner.setIncludes(includes);
> } else {
> scanner.setIncludes(DEFAULT_INCLUDES);
> }
> if (excludes != null && excludes.length != 0) {
> scanner.setExcludes(excludes);
> }
> scanner.addDefaultExcludes();
> scanner.scan();
> {code}
> {{DirectoryScanner}} uses {{java.io.File.list()}}, which does not guarantee
> order.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
