elharo commented on code in PR #21:
URL:
https://github.com/apache/maven-changelog-plugin/pull/21#discussion_r1888886301
##########
pom.xml:
##########
@@ -371,7 +371,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-changelog-plugin</artifactId>
- <version>2.2</version>
+ <version>3.0.0-SNAPSHOT</version>
Review Comment:
Not sure if we're ready to change the version or not
##########
src/main/java/org/apache/maven/plugins/changelog/ChangeLogReport.java:
##########
@@ -1218,9 +1224,13 @@ private void doChangedSetDetail(ChangeSet entry, Sink
sink) {
sink.tableCell_();
sink.tableCell();
- // doRevision( entry.getFiles(), bundle, sink );
- doChangedFiles(entry.getFiles(), sink);
- sink.lineBreak();
+
+ if (displayFileAndRevInfo) {
+ // doRevision( entry.getFiles(), bundle, sink );
Review Comment:
delete commented code
##########
src/test/plugin-configs/changelog/display-file-and-rev-info-explicitly-plugin-config.xml:
##########
@@ -0,0 +1,44 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-changelog-plugin</artifactId>
+ <configuration>
+ <displayFileAndRevInfo>true</displayFileAndRevInfo>
+ <type>range</type>
+ <range>-1</range>
+ <dateFormat>yyyy-MM-dd</dateFormat>
+ <basedir>${basedir}/src/main/java</basedir>
+
<outputXML>${basedir}/src/test/changelog-xml/min-changelog.xml</outputXML>
+ <outputXMLExpiration>60</outputXMLExpiration>
+ <outputEncoding>ISO-8859-1</outputEncoding>
Review Comment:
why not UTF-8?
##########
src/test/plugin-configs/changelog/dont-display-file-and-rev-info-plugin-config.xml:
##########
@@ -0,0 +1,44 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-changelog-plugin</artifactId>
+ <configuration>
+ <displayFileAndRevInfo>false</displayFileAndRevInfo>
+ <type>range</type>
+ <range>-1</range>
+ <dateFormat>yyyy-MM-dd</dateFormat>
+ <basedir>${basedir}/src/main/java</basedir>
+
<outputXML>${basedir}/src/test/changelog-xml/min-changelog.xml</outputXML>
+ <outputXMLExpiration>60</outputXMLExpiration>
+ <outputEncoding>ISO-8859-1</outputEncoding>
Review Comment:
UTF-8?
##########
src/main/java/org/apache/maven/plugins/changelog/ChangeLogReport.java:
##########
@@ -283,6 +283,12 @@ public class ChangeLogReport extends AbstractMavenReport {
@Parameter(defaultValue = "connection", required = true)
private String connectionType;
+ /**
+ * If true, file and file revision information is displayed for each SCM
entry.
+ */
+ @Parameter(property = "displayFileAndRevInfo", defaultValue = "true")
+ private boolean displayFileAndRevInfo = true;
Review Comment:
perhaps false by default? What's the current behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
