[ 
https://issues.apache.org/jira/browse/MWRAPPER-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905910#comment-17905910
 ] 

ASF GitHub Bot commented on MWRAPPER-111:
-----------------------------------------

mhalbritter commented on PR #158:
URL: https://github.com/apache/maven-wrapper/pull/158#issuecomment-2544834840

   Thanks @slachiewicz !




> Failed to validate Maven Wrapper SHA-256 when properties file contains CRLF 
> line endings
> ----------------------------------------------------------------------------------------
>
>                 Key: MWRAPPER-111
>                 URL: https://issues.apache.org/jira/browse/MWRAPPER-111
>             Project: Maven Wrapper
>          Issue Type: Bug
>          Components: Maven Wrapper Scripts
>    Affects Versions: 3.2.0
>            Reporter: Jakub Stroleny
>            Assignee: Sylwester Lachiewicz
>            Priority: Major
>             Fix For: 3.3.3
>
>
> The maven wrapper checksum validation fails if maven-wrapper.properties 
> contains line endings with CRLF instead of LF, e.g. because git repository is 
> checked out using git core.autocrlf=true property.
> *Steps to reproduce:*
> 1) Have git repository with maven wrapper generated for project which 
> contains correct wrapperSha256Sum ** property in maven-wrapper.properties
> 2) Clone/Checkout git repository with core.autocrlf git property set to true
> 3) Check that maven-wrapper.properties file contains CRLF instead of original 
> LF line endings
> 4) Run e.g. $./mvnw clean package for project and let maven script to verify 
> checksum; the executed script is batch file (mvnw.cmd) version, not 
> powershell version (not sure if it works with ps script)
> *Expected result:*
> The maven execution validates correct checksum with no issue.
> *Actual Result:*
> Following error is produced and execution stops.
> {code:java}
> $ ./mvnw clean package
> Error: Failed to validate Maven wrapper SHA-256, your Maven wrapper might be 
> compromised.
> Investigate or delete .mvn/wrapper/maven-wrapper.jar to attempt a clean 
> download.
> If you updated your Maven version, you need to update the specified 
> wrapperSha256Sum property.{code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to