elharo commented on code in PR #32:
URL: 
https://github.com/apache/maven-assembly-plugin/pull/32#discussion_r1882181475

##########
src/test/java/org/apache/maven/plugins/assembly/filter/SimpleAggregatingDescriptorHandlerTest.java:
##########
@@ -0,0 +1,99 @@
+package org.apache.maven.plugins.assembly.filter;
+
+/*

Review Comment:
   license above package



##########
src/main/java/org/apache/maven/plugins/assembly/archive/archiver/AssemblyProxyArchiver.java:
##########
@@ -784,7 +785,15 @@ private boolean acceptFile( final File inputFile )
         {
             if ( selectors != null )
             {
-                final FileInfo fileInfo = new DefaultFileInfo( inputFile );
+                final FileInfo fileInfo;

Review Comment:
   use a larger try block, don't split initialization and declaration



##########
src/test/java/org/apache/maven/plugins/assembly/filter/AbstractLineAggregatingHandlerTest.java:
##########
@@ -0,0 +1,114 @@
+package org.apache.maven.plugins.assembly.filter;
+
+/*

Review Comment:
   License above package



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to