gnodet commented on code in PR #269:
URL: 
https://github.com/apache/maven-invoker-plugin/pull/269#discussion_r1874504869


##########
src/test/java/org/apache/maven/plugins/invoker/AbstractTestUtil.java:
##########
@@ -22,14 +22,15 @@
 
 import org.codehaus.plexus.util.ReflectionUtils;
 
+// TODO this should be a static utility class that does not require inheritance
 abstract class AbstractTestUtil {
 
     protected String getBasedir() {
         String path = System.getProperty("basedir");
         return path != null ? path : new File("").getAbsolutePath();
     }
 
-    protected void setVariableValueToObject(Object object, String filed, 
Object value) throws IllegalAccessException {

Review Comment:
   This method does not bring much value, is it needed at all ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to