gnodet commented on code in PR #267:
URL: 
https://github.com/apache/maven-invoker-plugin/pull/267#discussion_r1874504207


##########
src/main/java/org/apache/maven/plugins/invoker/InvokerSession.java:
##########
@@ -210,7 +212,8 @@ public void logFailedBuildLog(Log logger, boolean 
ignoreFailures) throws MojoFai
                     buildLogMessage.append(System.lineSeparator());
                     buildLogMessage.append("*** begin build.log for: " + 
buildJob.getProject() + " ***");
                     buildLogMessage.append(System.lineSeparator());
-                    try (FileReader buildLogReader = new 
FileReader(buildLogFile)) {
+                    try (Reader buildLogReader =
+                            Files.newBufferedReader(buildLogFile.toPath(), 
StandardCharsets.UTF_8)) {

Review Comment:
   No need to specify the UTF-8 encoding, that's [the default for the NIO File 
api](https://help.intrexx.com/apidocs/jdk17/api/java.base/java/nio/file/Files.html#newBufferedReader(java.nio.file.Path)).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to