Giovds commented on code in PR #244:
URL: https://github.com/apache/maven-archetype/pull/244#discussion_r1873721692


##########
archetype-models/archetype-descriptor/src/main/mdo/archetype-descriptor.mdo:
##########
@@ -162,6 +162,13 @@
           <required>false</required>
           <description>Encoding to use when filtering content.</description>
         </field>
+        <field xml.attribute="true">
+          <name>includeCondition</name>
+          <version>1.0.0+</version>

Review Comment:
   It should be backwards compatible so that's why I put it in v1.0.0, but I'm 
fine with both. I'm not sure what the implications would be when adding it for 
1.0.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to