bmarwell commented on PR #223:
URL: 
https://github.com/apache/maven-jlink-plugin/pull/223#issuecomment-2518442755

   Are we STILL on `javax.*`?  `+1` for not using `@Component` if supported. 
But `-0.1` for leaving out the public no-arg constructor. Tests might get 
cluttered. 
   
   WDYT of either:
   * setter injection
   * field injection
   * constructor injection
   
   ..? My preference is whatever most plugins already use to keep code 
consistent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to