elharo commented on code in PR #87:
URL:
https://github.com/apache/maven-changes-plugin/pull/87#discussion_r1865001507
##########
src/main/java/org/apache/maven/plugins/changes/ChangesReport.java:
##########
@@ -172,11 +173,9 @@ public class ChangesReport extends AbstractChangesReport {
@Parameter(property = "changes.xmlPath", defaultValue =
"src/changes/changes.xml")
private File xmlPath;
- private ReleaseUtils releaseUtils = new ReleaseUtils(getLog());
-
- private CaseInsensitiveMap caseInsensitiveIssueLinkTemplatePerSystem;
+ private final ReleaseUtils releaseUtils = new ReleaseUtils(getLog());
Review Comment:
This could be a little wonky, depending on what the getLog does. If it
depends on this object being initialized, it might not work like you expect. In
general avoid calling instance methods in constructors and field initializers.
##########
src/main/java/org/apache/maven/plugins/changes/ChangesReport.java:
##########
@@ -147,6 +147,7 @@ public class ChangesReport extends AbstractChangesReport {
private String team;
/**
+ *
Review Comment:
just delete this if you're not going to fill it in
##########
src/main/java/org/apache/maven/plugins/changes/issues/IssuesReportRenderer.java:
##########
@@ -153,89 +139,81 @@ private void constructHeaderRow(Sink sink, List<Issue>
issueList, ResourceBundle
sink.tableRow_();
}
- private void constructDetailRows(Sink sink, List<Issue> issueList,
ResourceBundle bundle, Locale locale) {
- if (issueList == null) {
- return;
- }
+ private void constructDetailRows() {
+
+ // Always use the international date format as recommended by the W3C:
+ // http://www.w3.org/QA/Tips/iso-date
+ // This date format is used in the Swedish locale.
Review Comment:
Why does this (Swedish) matter? It feels like a minor coincidence not
relevant to the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
