LogFlames opened a new pull request, #50:
URL: https://github.com/apache/maven-dependency-tree/pull/50
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/MSHARED) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MSHARED-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
-------
In maven-dependency-plugin there are multiple export formats for the
dependency tree, these include Json, DOT, GraphML etc. When creating the normal
tree all information is there to format it nicely as e.g. Json. However, when
running `mvn dependency:tree -Dverbose`, all nodes are included (as they are
VerboseDependencyNode) but since VerboseDependencyNode is internal in
maven-dependency-tree there is no (clean) way to include information of which
nodes are included or not (see
[https://issues.apache.org/jira/browse/MDEP-962](https://issues.apache.org/jira/browse/MDEP-962)).
The only current way to include this information would be to parse the
`toNodeString()` output (where excluded nodes are wrapped in parenthesis).
I propose to expose ConflictData on the DependencyNode and make it null for
DefaultDependencyNode to allow for more detailed information in the
machine-readable formats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
