[
https://issues.apache.org/jira/browse/MJAVADOC-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900302#comment-17900302
]
ASF GitHub Bot commented on MJAVADOC-823:
-----------------------------------------
olamy opened a new pull request, #343:
URL: https://github.com/apache/maven-javadoc-plugin/pull/343
Signed-off-by: Olivier Lamy <ol...@apache.org>
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A
more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> legacyMode keeps using module-info.java (-sourcedirectory still use as well
> as java files input)
> ------------------------------------------------------------------------------------------------
>
> Key: MJAVADOC-823
> URL: https://issues.apache.org/jira/browse/MJAVADOC-823
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: javadoc
> Affects Versions: 3.11.1
> Reporter: Olivier Lamy
> Assignee: Olivier Lamy
> Priority: Major
> Fix For: 3.11.2
>
>
> When using legacyMode, javadoc should ignore all module-info.java when
> building javadoc.
> But the plugin is still using -sourcepath option with a list of directories
> AND a file as argument with all .java files. This means for project partially
> converted to java modules, aggregated javadoc may work as javadoc will still
> see some module-info..java because of scanning directories.
> In legacy mode, we can remove the use of -sourcepath parameter
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
