[ 
https://issues.apache.org/jira/browse/MJLINK-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899484#comment-17899484
 ] 

ASF GitHub Bot commented on MJLINK-86:
--------------------------------------

rfscholte opened a new pull request, #221:
URL: https://github.com/apache/maven-jlink-plugin/pull/221

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [V] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MJLINK) filed 
          for the change (usually before you start working on it).  Trivial 
changes like typos do not 
          require a JIRA issue.  Your pull request should address just this 
issue, without 
          pulling in other changes.
    - [V] Each commit in the pull request should have a meaningful subject line 
and body.
    - [V] Format the pull request title like `[MJLINK-XXX] - Fixes bug in 
ApproximateQuantiles`,
          where you replace `MJLINK-XXX` with the appropriate JIRA issue. Best 
practice
          is to use the JIRA issue title in the pull request title and in the 
first line of the 
          commit message.
    - [V] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [V] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
          be performed on your pull request automatically.
    - [V] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [V] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> --suggested-providers must be the last argument
> -----------------------------------------------
>
>                 Key: MJLINK-86
>                 URL: https://issues.apache.org/jira/browse/MJLINK-86
>             Project: Maven JLink Plugin
>          Issue Type: Improvement
>            Reporter: Robert Scholte
>            Assignee: Robert Scholte
>            Priority: Major
>
> it is possible to show the suggested providers for a specific service (as 
> part of creating a jlink file), however that means that is has to be the last 
> argument (it is not ducumented, but in the code it is marked as a terminal 
> jlinktask).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to