[
https://issues.apache.org/jira/browse/SUREFIRE-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Mortagne updated SUREFIRE-2286:
--------------------------------------
Description:
While more classic junit4 tests are executed and reported fine, it seems that
[test generated through a custom
@RunWith|https://github.com/xwiki/xwiki-rendering/blob/xwiki-rendering-16.9.0/xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki21/src/test/java/org/xwiki/rendering/internal/xwiki21/XWiki21CompatibilityTest.java]
are executed (some logs are produced which can only mean that those tests are
indeed executed), but their result does not appear in the Surefire report.
Problem is that it means the build never fail even if one of those tests is
actually not passing, we've finally noticed it only after a while...
Downgrading to 2.22.2 make the tests behave as expected.
Note that those test classes are handled properly when adding
{{org.apache.maven.surefire:surefire-junit47}} to the surefire plugin's
dependencies, but it causes problems with our junit 5 tests, unfortunately, and
we have quite a few modules in which both versions of junit are used (in
different test classes, of course).
was:
While more classic junit4 tests are executed and reported fine, it seems that
[test generated through a custom
@RunWith|https://github.com/xwiki/xwiki-rendering/blob/xwiki-rendering-16.9.0/xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki21/src/test/java/org/xwiki/rendering/internal/xwiki21/XWiki21CompatibilityTest.java]
are executed (some logs are produced which can only mean that those tests are
indeed executed), but their result does not appear in the Surefire report.
Problem is that it means the build never fail even if one of those tests is
actually not passing, we've finally noticed it only after a while...
Downgrading to 2.22.2 make the tests behave as expected.
Note that those test classes are handled properly when adding
{{org.apache.maven.surefire:surefire-junit47}} to the surefire plugin's
dependencies, but it causes problems with our junit 5 tests, unfortunately, and
we have quite a few modules in which both types of test classes are present.
> Surefire 3.x is ignoring the result of @RunWith-based junit4 tests
> ------------------------------------------------------------------
>
> Key: SUREFIRE-2286
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2286
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support
> Affects Versions: 3.0.0
> Reporter: Thomas Mortagne
> Priority: Major
>
> While more classic junit4 tests are executed and reported fine, it seems that
> [test generated through a custom
> @RunWith|https://github.com/xwiki/xwiki-rendering/blob/xwiki-rendering-16.9.0/xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki21/src/test/java/org/xwiki/rendering/internal/xwiki21/XWiki21CompatibilityTest.java]
> are executed (some logs are produced which can only mean that those tests
> are indeed executed), but their result does not appear in the Surefire report.
> Problem is that it means the build never fail even if one of those tests is
> actually not passing, we've finally noticed it only after a while...
> Downgrading to 2.22.2 make the tests behave as expected.
> Note that those test classes are handled properly when adding
> {{org.apache.maven.surefire:surefire-junit47}} to the surefire plugin's
> dependencies, but it causes problems with our junit 5 tests, unfortunately,
> and we have quite a few modules in which both versions of junit are used (in
> different test classes, of course).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
