JackPGreen commented on PR #155: URL: https://github.com/apache/maven-checkstyle-plugin/pull/155#issuecomment-2460846930
> Looks good. I would only request a chance on name of class to be something like MavenConsoleLogger > > https://github.com/checkstyle/checkstyle/blob/aadc3771a2219e784cd7611213fd7f6534da7cb8/src/main/java/com/puppycrawl/tools/checkstyle/DefaultLogger.java#L42 > To be clear, are you requesting I rename the [`ConsoleListener` class](https://github.com/apache/maven-checkstyle-plugin/blob/91ca4b84368e680b5665b09fea500f65a6a111ae/src/main/java/org/apache/maven/plugins/checkstyle/ConsoleListener.java) to something like `MavenLoggingListener`? > To MavenConsoleLogger > > But if there are some concerns, I am ok with any name. This is not a project where I enforce rules. Updated - https://github.com/apache/maven-checkstyle-plugin/pull/155/commits/ab8afc01f8837684b195559981901a26c6a91a82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
