[
https://issues.apache.org/jira/browse/MCLEAN-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895962#comment-17895962
]
Peter De Maeyer edited comment on MCLEAN-110 at 11/6/24 1:39 PM:
-----------------------------------------------------------------
I created a PR where I removed {{Utils.createSymlink}}, replacing its usages
with {{Files.createSymbolicLink}}. I worked around the BeanShell varargs
limitation by passing explicit zero-length arrays.
* [The version of BeanShell in Apache Maven is really
old.|https://mvnrepository.com/artifact/org.apache-extras.beanshell/bsh] [Newer
versions of BeanShell allegedly support
varargs.|https://github.com/beanshell/beanshell/commit/c1adf5d]
* I considered using Groovy instead of BeanShell, but it would have been a
bigger diff and it would become inconsistent with other integration tests
→ I left it alone.
was (Author: peterdm):
I created a PR where I removed {{Utils.createSymlink}}, replacing its usages
with {{Files.createSymbolicLink}}. I worked around the BeanShell varargs
limitation by passing explicit zero-length arrays.
* [The version of BeanShell in Apache Maven is really
old.|https://mvnrepository.com/artifact/org.apache-extras.beanshell/bsh] [Newer
versions of BeanShell allegedly support
varargs.|https://github.com/beanshell/beanshell/commit/c1adf5d]
* I considered using Groovy instead of BeanShell, but it would have been a
bigger diff and it would become inconsistent with other integration tests
→ out of scope.
> Utils.createSymlink should be replace by Java 7 code
> ----------------------------------------------------
>
> Key: MCLEAN-110
> URL: https://issues.apache.org/jira/browse/MCLEAN-110
> Project: Maven Clean Plugin
> Issue Type: Improvement
> Reporter: Elliotte Rusty Harold
> Priority: Major
> Labels: up-for-grabs
>
> instead of shelling out to command line
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
