michael-o commented on PR #788:
URL: https://github.com/apache/maven-surefire/pull/788#issuecomment-2446127015

   > > Does this still hold true after your change: 
https://maven.apache.org/surefire/maven-surefire-plugin/examples/rerun-failing-tests.html?
   > 
   > Here's an abbreviated surefire report XML:
   > 
   > ```
   > <testsuite ...>
   >   ...
   >   <testcase name="testTemplatePartiallyFails()[1]" 
classname="pkg.FieldSettingTest" time="0.012">
   >     <failure message="expected: &lt;42&gt; but was: &lt;0&gt;" 
type="org.opentest4j.AssertionFailedError">
   >     ...
   >     </failure>
   >     <rerunFailure message="expected: &lt;42&gt; but was: &lt;0&gt;" 
type="org.opentest4j.AssertionFailedError">
   >     ...
   >     </rerunFailure>
   >   </testcase>
   >   <testcase name="testTemplatePartiallyFails()[2]" 
classname="pkg.FieldSettingTest" time="0.001"/>
   > </testsuite>
   > ```
   > 
   > And here's a snippet from the logs:
   > 
   > ```
   > [INFO] Results:
   > [INFO] 
   > [ERROR] Failures: 
   > [ERROR] pkg.FieldSettingTest.testTemplatePartiallyFails()[1]
   > [ERROR]   Run 1: FieldSettingTest.testTemplatePartiallyFails:28 expected: 
<42> but was: <0>
   > [ERROR]   Run 2: FieldSettingTest.testTemplatePartiallyFails:28 expected: 
<42> but was: <0>
   > [INFO] 
   > [INFO] 
   > [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0
   > ```
   > 
   > As intended, there is no mention of flakes.
   
   That's not what I meant. Rephrasing: After the change from your has been 
applied, is the information on that valid still valid and true or does it 
require modification? In other words: The page describes the ideal behavior and 
the code was wrong previously because it did not cover this specific case?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to