gnodet commented on code in PR #587:
URL: https://github.com/apache/maven-resolver/pull/587#discussion_r1812881659
##########
maven-resolver-transport-apache/src/main/java/org/eclipse/aether/transport/apache/ApacheTransporter.java:
##########
@@ -288,16 +288,20 @@ final class ApacheTransporter extends AbstractTransporter
implements HttpTranspo
.register(AuthSchemes.KERBEROS, new KerberosSchemeFactory())
.build();
SocketConfig socketConfig =
- SocketConfig.custom().setSoTimeout(requestTimeout).build();
+ // the time to establish connection (low level)
+ SocketConfig.custom().setSoTimeout(connectTimeout).build();
Review Comment:
SO timeout is the read timeout on the socket, so the maximum amount of time
between two packets (or, on the server side, the max time for `accept()`). So
I don't think it should be set to `connectTimeout`.
How does this timeout work wrt to the socket timeout below ? Is the timeout
on the `SocketConfig` used when no value is set on `RequestConfig` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
