[ 
https://issues.apache.org/jira/browse/MDEP-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891835#comment-17891835
 ] 
ASF GitHub Bot commented on MDEP-960:
-------------------------------------

elharo commented on PR #447:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/447#issuecomment-2429159956

   Yes, I'm not sure why this was done like this in the first place. This has 
been around since 2.0 so who knows? I am confident the way it was done is 
buggy, so this tries to repair as much of it as I easily could. I noticed 
because the tests mixed up two different silent log classes. Someone wasn't 
following test first practices when they wrote this.
   
   If we're comfortable with some incompatibility, then we could mke the silent 
parameter and associated methods noops.
   
   
   




> Silent logging somewhat broken in AbstractDependencyMojo
> --------------------------------------------------------
>
>                 Key: MDEP-960
>                 URL: https://issues.apache.org/jira/browse/MDEP-960
>             Project: Maven Dependency Plugin
>          Issue Type: Bug
>            Reporter: Elliotte Rusty Harold
>            Assignee: Elliotte Rusty Harold
>            Priority: Minor
>
> There's confusion between different SilentLogger classes, as well as  a 
> failure to reset the logger to non-silent when asked. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to