Giovds commented on code in PR #234:
URL: https://github.com/apache/maven-archetype/pull/234#discussion_r1808446829
##########
archetype-common/src/main/java/org/apache/maven/archetype/DefaultArchetypeManager.java:
##########
@@ -146,6 +146,7 @@ public ArchetypeCatalog getInternalCatalog() {
return source.getArchetypeCatalog(null, null);
} catch (ArchetypeDataSourceException e) {
+ getLogger().warn("failed to read catalog", e);
Review Comment:
That is a fair point. My initial idea was to `logError()` and throw an
exception. But I noticed we already did `logWarning()` instead for remote
catalog. In a way it can make sense to continue with the build and warn because
you one catalog might fail, but others might not when you use
`-DarchetypeCatalog=local,internal`.
I wanted to match that behaviour, I'll update the PR and ticket title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]