[ 
https://issues.apache.org/jira/browse/MARTIFACT-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891418#comment-17891418
 ] 

ASF GitHub Bot commented on MARTIFACT-75:
-----------------------------------------

hboutemy commented on PR #66:
URL: 
https://github.com/apache/maven-artifact-plugin/pull/66#issuecomment-2425726289

   this does not really solve the issue, but just makes it less visible:
   ```
   [WARNING] Corrupt jar file 
/Users/hboutemy/dev/maven/plugins/tools/maven-help-plugin/target/reference/org.apache.maven.plugins/maven-help-plugin-3.5.0.pom
   zip END header not found
   ```
   
   as fixed in #67, trying to open a .pom file as a jar is just a bug, not 
corrupted zip
   
   when an issue is found openeing archive, having the full stack trace is IMHO 
useful to differentiate between bug like currently vs reqally corrupted zip 
(like nobody ever reported)




> stacktrace when running compare
> -------------------------------
>
>                 Key: MARTIFACT-75
>                 URL: https://issues.apache.org/jira/browse/MARTIFACT-75
>             Project: Maven Artifact Plugin
>          Issue Type: Bug
>          Components: artifact:compare
>    Affects Versions: 3.5.2
>            Reporter: Herve Boutemy
>            Assignee: Elliotte Rusty Harold
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.5.3
>
>
> # when rebuilding 
> https://github.com/jvm-repo-rebuild/reproducible-central/pull/437
> just a warning, does not fail anything, but noisy
> {noformat}
> [INFO] --- artifact:3.5.2:compare (default-cli) @ nisse ---
> [INFO] Reference buildinfo file not found: it will be generated from 
> downloaded reference artifacts
> [WARNING] unable to open jar file 
> /var/maven/app/target/reference/eu.maveniverse.maven.nisse/nisse-0.3.3.pom
> java.util.zip.ZipException: zip END header not found
>     at java.util.zip.ZipFile$Source.findEND (ZipFile.java:1649)
>     at java.util.zip.ZipFile$Source.initCEN (ZipFile.java:1657)
>     at java.util.zip.ZipFile$Source.<init> (ZipFile.java:1495)
>     at java.util.zip.ZipFile$Source.get (ZipFile.java:1458)
>     at java.util.zip.ZipFile$CleanableResource.<init> (ZipFile.java:724)
>     at java.util.zip.ZipFile.<init> (ZipFile.java:251)
>     at java.util.zip.ZipFile.<init> (ZipFile.java:180)
>     at java.util.jar.JarFile.<init> (JarFile.java:345)
>     at java.util.jar.JarFile.<init> (JarFile.java:316)
>     at java.util.jar.JarFile.<init> (JarFile.java:282)
>     at 
> org.apache.maven.plugins.artifact.buildinfo.ReferenceBuildinfoUtil.extractEnv 
> (ReferenceBuildinfoUtil.java:207)
>     at 
> org.apache.maven.plugins.artifact.buildinfo.ReferenceBuildinfoUtil.downloadOrCreateReferenceBuildinfo
>  (ReferenceBuildinfoUtil.java:131)
>     at 
> org.apache.maven.plugins.artifact.buildinfo.CompareMojo.downloadOrCreateReferenceBuildinfo
>  (CompareMojo.java:144)
>     at 
> org.apache.maven.plugins.artifact.buildinfo.CompareMojo.checkAgainstReference 
> (CompareMojo.java:131)
>     at org.apache.maven.plugins.artifact.buildinfo.CompareMojo.skip 
> (CompareMojo.java:115)
>     at 
> org.apache.maven.plugins.artifact.buildinfo.AbstractBuildinfoMojo.execute 
> (AbstractBuildinfoMojo.java:160)
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:126)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to