Giovds commented on PR #232: URL: https://github.com/apache/maven-archetype/pull/232#issuecomment-2423781649
@slawekjaranowski I'm not sure if you are the right person to ask, but I see you have been working on the plugin recently. What do you think of the change regarding the integration tests (see description of this PR)? >I had to change some existing integration tests, because apparently it is possible to add non-existing properties to an archetype in the integration-test goal, while this is not possible when using the generate goal. I've tried to add non-existing properties through the command line; both with -DsomeProp=test and through a properties file -Darchetype.properties=./archetype.properties. <br/> In both cases I was unable to include them while generating an archetype, which leads me to believe the integration test adding those properties to the archetype configuration is wrong compared to the actual implementation. It now matches the replacing of properties correctly. Hence the changes in the existing integration tests. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
