[
https://issues.apache.org/jira/browse/MSHARED-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890941#comment-17890941
]
ASF GitHub Bot commented on MSHARED-1446:
-----------------------------------------
michael-o opened a new pull request, #73:
URL: https://github.com/apache/maven-archiver/pull/73
This closes #73
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MSHARED) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MSHARED-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Add docs about repro build output timestamp boundaries
> ------------------------------------------------------
>
> Key: MSHARED-1446
> URL: https://issues.apache.org/jira/browse/MSHARED-1446
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-archiver
> Affects Versions: maven-archiver-3.6.2
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: maven-archiver-4.0.0, maven-archiver-3.6.3,
> maven-archiver-4.0.0-beta-2
>
>
> In MSHARED-1067 the boundaries have been introduced, but never documented by
> they actually exist. Reason: MS-DOS time limitation for 2+2 bytes starting
> from 1980. See ZIP note:
> {quote}
> 4.4.6 date and time fields: (2 bytes each)
> The date and time are encoded in standard MS-DOS format.
> If input came from standard input, the date and time are
> those at which compression was started for this data.
> If encrypting the central directory and general purpose bit
> flag 13 is set indicating masking, the value stored in the
> Local Header will be zero. MS-DOS time format is different
> from more commonly used computer time formats such as
> UTC. For example, MS-DOS uses year values relative to 1980
> and 2 second precision.
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
