[
https://issues.apache.org/jira/browse/MPH-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890812#comment-17890812
]
ASF GitHub Bot commented on MPH-193:
------------------------------------
michael-o opened a new pull request, #123:
URL: https://github.com/apache/maven-help-plugin/pull/123
This closes #123
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MPH) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MPH-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MPH-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Document charset for evaluate goal file output
> ----------------------------------------------
>
> Key: MPH-193
> URL: https://issues.apache.org/jira/browse/MPH-193
> Project: Maven Help Plugin
> Issue Type: Improvement
> Components: evaluate
> Affects Versions: 3.3.0
> Reporter: Garret Wilson
> Assignee: Michael Osipov
> Priority: Minor
> Fix For: 3.5.1
>
>
> I'm using Java 17 on Windows with
> `org.apache.maven.plugins:maven-help-plugin:3.3.0`. The
> [{{<output>}}|https://maven.apache.org/plugins/maven-help-plugin/evaluate-mojo.html#output]
> option allows the evaluated information to be sent to a file. But the
> documentation does not say which charset will be used!
> I was afraid that you might be using the system default charset (which would
> be very bad). But I did a test:
> {code:xml}
> <properties>
> <foo><![CDATA[<bar>touché 😃</bar>]]></foo>
> </properties>
> …
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-help-plugin</artifactId>
> <executions>
> <execution>
> <id>foobar</id>
> <phase>generate-resources</phase>
> <goals>
> <goal>evaluate</goal>
> </goals>
> <configuration>
> <expression>foo</expression>
> <output>${project.build.directory}/foo.xml</output>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
> It was a huge relief to find that the output file {{foo.xml}} contained the
> word "touché" followed by a smiley face emoticon, encoded in UTF-8!
> It is a very good thing that you are encoding the file output in UTF-8 and
> not some arbitrary, per-system encoding. But this needs to be documented so
> we'll know that we can depend on that. Thank you.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
