[ https://issues.apache.org/jira/browse/MSHARED-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889335#comment-17889335 ]
Michael Osipov commented on MSHARED-1445: ----------------------------------------- Shit, I have unintentionally pushed to master: https://github.com/apache/maven-archiver/commit/f7565830c499a758c78a16fa024124113e1b713c Should I revert and create a PR again? I need to cherry-pick to 3.6.x... > Unix timestamps since the epoch are not subject to the boundary checks > ---------------------------------------------------------------------- > > Key: MSHARED-1445 > URL: https://issues.apache.org/jira/browse/MSHARED-1445 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-archiver > Affects Versions: maven-archiver-3.6.2 > Reporter: Michael Osipov > Assignee: Michael Osipov > Priority: Critical > Fix For: maven-archiver-4.0.0, maven-archiver-3.6.3, > maven-archiver-4.0.0-beta-2 > > > The Javadoc says: > {noformat} > * @throws IllegalArgumentException if the outputTimestamp is neither ISO 8601 > nor an integer, or it's not within > * the valid range 1980-01-01T00:00:02Z to 2099-12-31T23:59:59Z > {noformat} > but when a Unix timestamp since the epoch is passed it is simply passed > through. No min/max check. We need to fix this. -- This message was sent by Atlassian Jira (v8.20.10#820010)