[
https://issues.apache.org/jira/browse/MDEP-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888931#comment-17888931
]
ASF GitHub Bot commented on MDEP-956:
-------------------------------------
michael-o commented on code in PR #436:
URL:
https://github.com/apache/maven-dependency-plugin/pull/436#discussion_r1797755849
##########
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##########
@@ -51,18 +47,16 @@ public CopyUtil(BuildContext buildContext) {
}
/**
- * Does the actual copy of the artifact (file) and logging.
+ * Copies the artifact (file).
*
- * @param sourceArtifact represents the artifact (file) to copy.
- * @param destination file name of destination file.
+ * @param sourceArtifact represents the artifact (file) to copy
+ * @param destination file name of destination file
* @throws IOException if copy has failed
* @throws MojoExecutionException if artifact file is a directory (which
has not been packaged yet)
*
* @since 3.7.0
*/
public void copyArtifactFile(Artifact sourceArtifact, File destination)
throws IOException, MojoExecutionException {
- logger.info("Copying artifact '{}' ({}) to {}", sourceArtifact,
sourceArtifact.getFile(), destination);
Review Comment:
Why not move to debug level?
> silent parameter is not taken into account
> ------------------------------------------
>
> Key: MDEP-956
> URL: https://issues.apache.org/jira/browse/MDEP-956
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: copy-dependencies
> Affects Versions: 3.7.0, 3.7.1, 3.8.0
> Reporter: Philippe De Neve
> Assignee: Elliotte Rusty Harold
> Priority: Minor
>
> When setting the {{silent}} parameter to {{{}true{}}}, the
> {{copy-dependencies}} goal remains non-silent.
> To reproduce:
> {code:bash}
> git clone https://gitlab.com/philippedn/jli.git
> cd jli/demos/jfxm
> mvn prepare-package # silent parameter set to true in pom.xml
> {code}
> Output:
> {code:bash}
> ...
> [INFO] Copying artifact 'org.openjfx:javafx-controls:jar:22.0.2:compile'
> (/mnt/storage/maven-repository/org/openjfx/javafx-controls/22.0.2/javafx-controls-22.0.2.jar)
> to
> /mnt/storage/code/scripts/jli/demos/jfxm/target/jars/javafx-controls-22.0.2.jar
> [INFO] Copying artifact
> 'org.openjfx:javafx-controls:jar:linux:22.0.2:compile'
> (/mnt/storage/maven-repository/org/openjfx/javafx-controls/22.0.2/javafx-controls-22.0.2-linux.jar)
> to
> /mnt/storage/code/scripts/jli/demos/jfxm/target/jars/javafx-controls-22.0.2.jar
> [INFO] Copying artifact 'org.openjfx:javafx-graphics:jar:22.0.2:compile'
> (/mnt/storage/maven-repository/org/openjfx/javafx-graphics/22.0.2/javafx-graphics-22.0.2.jar)
> to
> /mnt/storage/code/scripts/jli/demos/jfxm/target/jars/javafx-graphics-22.0.2.jar
> [INFO] Copying artifact
> 'org.openjfx:javafx-graphics:jar:linux:22.0.2:compile'
> (/mnt/storage/maven-repository/org/openjfx/javafx-graphics/22.0.2/javafx-graphics-22.0.2-linux.jar)
> to
> /mnt/storage/code/scripts/jli/demos/jfxm/target/jars/javafx-graphics-22.0.2.jar
> [INFO] Copying artifact 'org.openjfx:javafx-base:jar:22.0.2:compile'
> (/mnt/storage/maven-repository/org/openjfx/javafx-base/22.0.2/javafx-base-22.0.2.jar)
> to
> /mnt/storage/code/scripts/jli/demos/jfxm/target/jars/javafx-base-22.0.2.jar
> [INFO] Copying artifact 'org.openjfx:javafx-base:jar:linux:22.0.2:compile'
> (/mnt/storage/maven-repository/org/openjfx/javafx-base/22.0.2/javafx-base-22.0.2-linux.jar)
> to
> /mnt/storage/code/scripts/jli/demos/jfxm/target/jars/javafx-base-22.0.2.jar
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
