[ 
https://issues.apache.org/jira/browse/MJAVADOC-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888027#comment-17888027
 ] 

ASF GitHub Bot commented on MJAVADOC-787:
-----------------------------------------

laurentgo opened a new pull request, #326:
URL: https://github.com/apache/maven-javadoc-plugin/pull/326

   Similar to MCOMPILER-582, automatically disregard the `--release` flag for 
javadoc version < 9
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
          for the change (usually before you start working on it).  Trivial 
changes like typos do not
          require a JIRA issue.  Your pull request should address just this 
issue, without
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line 
and body.
    - [x] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in 
ApproximateQuantiles`,
          where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. 
Best practice
          is to use the JIRA issue title in the pull request title and in the 
first line of the
          commit message.
    - [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [x] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A 
more thorough check will
          be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Automatic detection of release option for JDK < 9
> -------------------------------------------------
>
>                 Key: MJAVADOC-787
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-787
>             Project: Maven Javadoc Plugin
>          Issue Type: New Feature
>          Components: javadoc
>    Affects Versions: 3.6.3
>            Reporter: Jorge Solórzano
>            Priority: Major
>
> The maven-compiler-plugin 3.13.0 now has detection of the release option:
>  * https://issues.apache.org/jira/browse/MCOMPILER-582
> But this should be expanded to maven-javadoc-plugin as well; this will allow 
> the use of a global property like:
> {code:xml}
> <maven.compiler.release>${javaVersion}</maven.compiler.release>
> {code}
> and not fail if the javadoc is generated on JDK 8.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to