[
https://issues.apache.org/jira/browse/MSCMPUB-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MSCMPUB-70:
-----------------------------------
Description:
The {{publish-scm}} goal has an
1. {{includes}}
(https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L152)
and
2. {{excludes}}
(https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L146)
parameter which are passed as {{FileSet}}
(https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L381)
to either
{{ScmProvider.checkout(...)}} or {{ScmProvider.update(...)}}.
I have quickly checked the implementation of SVN and Git and it seems that only
the basedir of the {{ScmFileSet}} is ever considered for checkout and update.
For the actual commit (delete, add or update) they are not used at all.
So to me it seems that those parameters never have any effect and should be
removed.
was:
The {{publish-scm}} goal has an
1. {{includes}}
(https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L152)
and
2. {{excludes}}
(https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L146)
parameter which are passed as {{FileSet}}
(https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L381)
to either
{{ScmProvider.checkout(...)}} or {{ScmProvider.update(...)}}.
I have quickly checked the implementation of SVN and Git and it seems that only
the basedir of the {{ScmFileSet}} is ever considered for checkout and update.
So to me it seems that those parameters never have any effect and should be
removed.
For the actual commit (delete, add or update) they are not used at all.
> Remove include/exclude parameters
> ---------------------------------
>
> Key: MSCMPUB-70
> URL: https://issues.apache.org/jira/browse/MSCMPUB-70
> Project: Maven SCM Publish Plugin
> Issue Type: Improvement
> Affects Versions: 3.3.0
> Reporter: Konrad Windszus
> Priority: Major
>
> The {{publish-scm}} goal has an
> 1. {{includes}}
> (https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L152)
> and
> 2. {{excludes}}
> (https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L146)
> parameter which are passed as {{FileSet}}
> (https://github.com/apache/maven-scm-publish-plugin/blob/6e26e03570966a9c65c8cc16d8dc6615777207e2/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L381)
> to either
> {{ScmProvider.checkout(...)}} or {{ScmProvider.update(...)}}.
> I have quickly checked the implementation of SVN and Git and it seems that
> only the basedir of the {{ScmFileSet}} is ever considered for checkout and
> update.
> For the actual commit (delete, add or update) they are not used at all.
> So to me it seems that those parameters never have any effect and should be
> removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
