[
https://issues.apache.org/jira/browse/MNG-8258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884639#comment-17884639
]
Herve Boutemy edited comment on MNG-8258 at 9/25/24 3:06 PM:
-------------------------------------------------------------
bq. Would it be possible to get the warning from Maven instead of having to run
a plugin to find that ?
of course, plugin code can go into Maven core: but is it a good idea?
for example: do we code enforcer's JDK and Maven minimum version checks into
core, or let the plugin do its job when people are interested to check?
the spirit for now is: have a reasonable default even if basic, let people
override if they are more opinionated (disable or get a value dedicated to
their project instead of default)
adding warning for people who don't care is just causing friction (the type of
friction we removed when adding default encodings)
was (Author: hboutemy):
bq. Would it be possible to get the warning from Maven instead of having to run
a plugin to find that ?
of course, plugin code can go into Maven core: but is it a good idea?
for example: do we code enforcer's JDK and Maven minimum version checks into
core, or le the plugin do its job when people are interested to check?
the spirit for now is: have a reasonable default even if basic, let people
override if they are more opinionated (disable or get a value dedicated to
their project instead of default)
adding warning for people who don't care is just causing friction (the type of
friction we removed when adding default encodings)
> activate Reproducible Builds by default
> ---------------------------------------
>
> Key: MNG-8258
> URL: https://issues.apache.org/jira/browse/MNG-8258
> Project: Maven
> Issue Type: New Feature
> Components: Core
> Affects Versions: 3.9.9, 4.0.0-beta-4
> Reporter: Herve Boutemy
> Priority: Major
> Fix For: 4.0.0-beta-5
>
>
> Reproducible Builds is a good practice that is easy to enable: it would be
> nice to enable it by default, and have projects disable it of they really
> have a problem with the default bahaviour
> result can be checked by running {{mvn artifact:check-buildplan}} on a
> minimal pom.xml (to check that the PR does what it promised to do = enable RB
> by default):
> - before: {{[ERROR] Reproducible Build not activated by
> project.build.outputTimestamp property: see
> https://maven.apache.org/guides/mini/guide-reproducible-builds.html}}
> - after: {{[WARNING] <project.build.outputTimestamp> property is inherited,
> it should be defined in pom.xml}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
