[ 
https://issues.apache.org/jira/browse/MGPG-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883827#comment-17883827
 ] 

Tamas Cservenak commented on MGPG-136:
--------------------------------------

Howdy Gili, thanks for reaching back with new info, and sorry for a bit late 
response.
You pointed at line that is "highly suspicious way of reading environment 
variables", so let me start there:
Maven at "boot" collects Java System Properties  and env variables into Maven 
System Properties (not to be confused with Java System Properties, that are ONE 
SOURCE of these). Same things happens in Toolbox (and there you confirmed that 
env.MAVEN_GPG_PASSPHRASE contains a secret value). And don't be confused, the 
"env." prefix is nothing to do with PowerShell or whatever, it is really just 
Maven:
See 
https://github.com/apache/maven/blob/45201347c417896b57159221130333f5fa4bbfb6/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L1485
And 
https://github.com/apache/maven/blob/45f9b81b4a8451a75864ef1c861c5bb201a54790/maven-core/src/main/java/org/apache/maven/properties/internal/EnvironmentUtils.java#L34

In short, Maven system properties contain Java System Properties (as is) AND 
env variables where key are prefixed with "env.". Hence the way of "reading".

Also, just like between Linux/MacOS/Windows, these differences _should_ be 
handled by Java, am pretty sceptic that in Java you should key env variable 
differently based on cmd/powershell... or if this is the case on Windows, that 
this platform is eeek.

> "gpg: signing failed: Bad passphrase" on GitHub Windows runners
> ---------------------------------------------------------------
>
>                 Key: MGPG-136
>                 URL: https://issues.apache.org/jira/browse/MGPG-136
>             Project: Maven GPG Plugin
>          Issue Type: Bug
>    Affects Versions: 3.2.0, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.5
>         Environment: Apache Maven 3.9.6 
> (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: 
> C:\Users\runneradmin\.m2\wrapper\dists\apache-maven-3.9.6-bin\3311e1d4\apache-maven-3.9.6
> Java version: 1.8.0_422, vendor: Azul Systems, Inc., runtime: 
> C:\hostedtoolcache\windows\Java_Zulu_jdk\8.0.422-5\x64\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows server 2022", version: "10.0", arch: "aarch64", family: 
> "windows"
>            Reporter: Gili
>            Priority: Critical
>
> Version 3.2.0 - 3.2.5 fail with "gpg: signing failed: Bad passphrase" on 
> GitHub Windows Runners.
> Using Linux or downgrading to version 3.1.0 seems to work fine.
> It's not clear what changed in these newer versions but 
> [https://github.com/apache/maven-gpg-plugin/blob/3a31714e9cbdde86a6b12f1ef05d5c60252fef4a/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L368]
>  looks like a highly supicious way of reading environment variables. It's 
> possible that this approach does not work properly under Powershell.
> If I echo "$env:MAVEN_GPG_PASSPHRASE" on the GitHub Windows runner, I get 
> back the correct value, so it sounds like there is a bug in the way that this 
> plugin is choosing to read the environment variable.
> What makes this a bit tricky, however, is that the environment variable is 
> called $MAVEN_GPG_PASSPHRASE on Linux, %MAVEN_GPG_PASSPHRASE% on cmd.exe and 
> $env:MAVEN_GPG_PASSPHRASE on Powershell. GitHub is using the Powershell 
> variant.
> Can you guys please look into this?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to