michael-o commented on PR #173: URL: https://github.com/apache/maven-doxia-sitetools/pull/173#issuecomment-2363210034
> > we have a conceptual flaw in our design > > Yes, but I am trying to fix this without breaking backwards compatibility. > > Having an additional parent on the site.xml level would fix this, but in most cases is highly redundant (and also isn't properly upgraded during release), so maintaining this on `site.xml` level would lead to a lot of additional challenges. > > Similar an additional dependency on the POM level feels highly redundant, because this should always reflect the Maven coordinates of the parent. Also knowledge about classifier (potentially extended with locale) requires additional knowledge from consumers they shouldn't necessarily know about. > > So just having a boolean toggle is IMHO the option with least redundancy and simplest to understand from a consumer PoV. Let me crunch on this...I am we are already breaking stuff. This would be ideal for now because we won't have another chance soon to break it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
