[
https://issues.apache.org/jira/browse/SUREFIRE-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883188#comment-17883188
]
ASF GitHub Bot commented on SUREFIRE-2226:
------------------------------------------
michael-o commented on code in PR #706:
URL: https://github.com/apache/maven-surefire/pull/706#discussion_r1768174827
##########
surefire-its/src/test/java/org/apache/maven/surefire/its/fixture/MavenLauncher.java:
##########
@@ -259,21 +260,14 @@ public OutputValidator execute(String goal) {
public OutputValidator executeCurrentGoals() {
try {
- List<String> goalsAndProps = new ArrayList<>(goals);
-
- for (Entry<String, String> e : props.entrySet()) {
- String key = e.getKey();
- String val = e.getValue();
- goalsAndProps.add(val == null ? "-D" + key : "-D" + key + "="
+ val);
- }
-
- getVerifier().setCliOptions(cliOptions);
- getVerifier().executeGoals(goalsAndProps, envVars);
+ getVerifier().addCliArguments(cliOptions.toArray(new String[] {}));
Review Comment:
`new String[0]` is sufficient
> Upgrade to Maven Verifier 2.0.0-M1
> ----------------------------------
>
> Key: SUREFIRE-2226
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2226
> Project: Maven Surefire
> Issue Type: Dependency upgrade
> Affects Versions: 3.2.3
> Reporter: Michael Osipov
> Assignee: Slawomir Jaranowski
> Priority: Major
> Fix For: 3.5.1
>
>
> This isn't just a dependency upgrade. Tasks to be done:
> * Align import package name
> * Replace usage of deprecated methods
> * Make use consistently of CLI arguments which contains options, goals,
> phases and user properties
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
