[
https://issues.apache.org/jira/browse/SUREFIRE-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883114#comment-17883114
]
ASF GitHub Bot commented on SUREFIRE-1737:
------------------------------------------
slawekjaranowski opened a new pull request, #780:
URL: https://github.com/apache/maven-surefire/pull/780
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Disabling the JUnit5Xml30StatelessReporter has no effect
> ---------------------------------------------------------
>
> Key: SUREFIRE-1737
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1737
> Project: Maven Surefire
> Issue Type: Bug
> Affects Versions: 3.0.0-M4
> Reporter: Dietrich Schulten
> Assignee: Slawomir Jaranowski
> Priority: Major
> Fix For: 3.5.1
>
>
> I have the following configuration for JUnit 5 display names:
> {code:java}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <version>3.0.0-M4</version>
> <configuration>
> <statelessTestsetReporter
> implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5Xml30StatelessReporter">
> <disable>true</disable>
> <usePhrasedFileName>true</usePhrasedFileName>
> <usePhrasedTestSuiteClassName>true</usePhrasedTestSuiteClassName>
> <usePhrasedTestCaseClassName>true</usePhrasedTestCaseClassName>
> <usePhrasedTestCaseMethodName>true</usePhrasedTestCaseMethodName>
> </statelessTestsetReporter>
> </configuration>
> </plugin>{code}
> Based on the disable flag, the {{JUnit5Xml30StatelessReporter}} should be
> {{disabled}}, but it evaluates display names according to the
> {{usePhrasedXXX}} flags.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
