[
https://issues.apache.org/jira/browse/MSKINS-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881634#comment-17881634
]
ASF GitHub Bot commented on MSKINS-242:
---------------------------------------
michael-o commented on code in PR #65:
URL: https://github.com/apache/maven-fluido-skin/pull/65#discussion_r1759203476
##########
src/main/resources/META-INF/maven/site-macros.vm:
##########
@@ -48,7 +48,7 @@
#**##end
#end
##
-#macro( link $link $icon = false $omitImage = false $elemOnEmptyHref = "a"
$dotSlashOnEmptyHref = false $imageClass = "imageLink" $overrideElemClass =
false )
+#macro( link $link $iconClass = null $omitImage = false $elemOnEmptyHref = "a"
$dotSlashOnEmptyHref = null $imageClass = "imageLink" $overrideElemClass = null
)
Review Comment:
This looks like a bug in GH, ignore it.
> Replace deprecated prettify JS library
> --------------------------------------
>
> Key: MSKINS-242
> URL: https://issues.apache.org/jira/browse/MSKINS-242
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Reporter: Konrad Windszus
> Priority: Major
> Fix For: fluido-2.0.0
>
>
> The JS library used for code highlighting in
> https://github.com/apache/maven-fluido-skin/blob/master/src/main/resources/js/prettify.js
> seems to be based on the legacy library
> https://github.com/googlearchive/code-prettify (unclear which version). As
> that is no longer maintained since quite a while we should switch.
> One alternative is [hightlight.js|https://highlightjs.org/](compare also with
> https://meta.stackexchange.com/questions/353983/goodbye-prettify-hello-highlight-js-swapping-out-our-syntax-highlighter).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
