[ 
https://issues.apache.org/jira/browse/MRESOLVER-600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881169#comment-17881169
 ] 

ASF GitHub Bot commented on MRESOLVER-600:
------------------------------------------

doddi commented on code in PR #576:
URL: https://github.com/apache/maven-resolver/pull/576#discussion_r1756127061


##########
maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/main/java/org/eclipse/aether/transport/jdk/JdkRFC9457Reporter.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.transport.jdk;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.http.HttpResponse;
+import java.util.Optional;
+
+import 
org.eclipse.aether.spi.connector.transport.http.HttpTransporterException;
+import org.eclipse.aether.spi.connector.transport.http.RFC9457.RFC9457Reporter;
+
+public class JdkRFC9457Reporter extends 
RFC9457Reporter<HttpResponse<InputStream>, HttpTransporterException> {
+    @Override
+    protected boolean isRFC9457Message(final HttpResponse<InputStream> 
response) {
+        Optional<String> optionalContentType = 
response.headers().firstValue("Content-Type");
+        if (optionalContentType.isPresent()) {
+            String contentType = optionalContentType.get();
+            return hasRFC9457ContentType(contentType);
+        }
+        return false;
+    }
+
+    @Override
+    protected int getStatusCode(final HttpResponse<InputStream> response) {
+        return response.statusCode();
+    }
+
+    @Override
+    protected String getReasonPhrase(final HttpResponse<InputStream> response) 
{
+        return null;
+    }
+
+    @Override
+    protected String getBody(final HttpResponse<InputStream> response) throws 
IOException {
+        try (InputStream is = response.body()) {
+            return new String(is.readAllBytes());

Review Comment:
   
https://github.com/apache/maven-resolver/pull/576/commits/156b09517904c13515839562084ac275797911a9



##########
maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-8/src/main/java/org/eclipse/aether/transport/jdk/JdkRFC9457Reporter.java:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.transport.jdk;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.net.HttpURLConnection;
+
+import 
org.eclipse.aether.spi.connector.transport.http.HttpTransporterException;
+import org.eclipse.aether.spi.connector.transport.http.RFC9457.RFC9457Reporter;
+
+public class JdkRFC9457Reporter extends RFC9457Reporter<HttpURLConnection, 
HttpTransporterException> {
+    @Override
+    protected boolean isRFC9457Message(final HttpURLConnection response) {
+        String contentType = response.getContentType();
+        return hasRFC9457ContentType(contentType);
+    }
+
+    @Override
+    protected int getStatusCode(final HttpURLConnection response) {
+        try {
+            return response.getResponseCode();
+        } catch (IOException e) {
+            return -1;
+        }
+    }
+
+    @Override
+    protected String getReasonPhrase(final HttpURLConnection response) {
+        return null;
+    }
+
+    @Override
+    protected String getBody(final HttpURLConnection response) throws 
IOException {
+        try (BufferedReader br = new BufferedReader(new 
InputStreamReader(response.getInputStream()))) {

Review Comment:
   
https://github.com/apache/maven-resolver/pull/576/commits/156b09517904c13515839562084ac275797911a9





> Implement RFC 9457
> ------------------
>
>                 Key: MRESOLVER-600
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-600
>             Project: Maven Resolver
>          Issue Type: New Feature
>          Components: Resolver
>            Reporter: Mark Dodgson
>            Priority: Minor
>
> HTTP1.1 [RFC 
> 9112|https://www.rfc-editor.org/rfc/rfc9112.html#name-status-line] section 4 
> defines the response status code to optionally include a text description 
> (human readable) of the reason for the status code.
> There is an additional [RFC9457|https://www.rfc-editor.org/rfc/rfc9457] which 
> makes use of the body to inform of a reason for the error response allowing 
> for easier investigation.
> h2. Why is this important
> [RFC9113|https://www.rfc-editor.org/rfc/rfc9113] is the HTTP2 protocol 
> standard and the response status only considers the [status 
> code|https://www.rfc-editor.org/rfc/rfc9113#name-response-pseudo-header-fiel] 
> and not the reason phrase, as such important information can be lost in 
> helping the client determine a route cause of a failure.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to