michael-o commented on code in PR #576: URL: https://github.com/apache/maven-resolver/pull/576#discussion_r1753623409
########## maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/http/RFC9457/RFC9457Reporter.java: ########## @@ -20,60 +20,65 @@ import java.io.IOException; +import com.google.gson.Gson; +import com.google.gson.JsonSyntaxException; + /** - * A reporter for RFC9457 messages. + * A reporter for RFC 9457 messages. * RFC9457 is a standard for reporting problems in HTTP responses as a JSON object. * There are members specified in the RFC but none of those appear to be required, * @see <a href=https://www.rfc-editor.org/rfc/rfc9457#section-3-7>rfc9457 section 3.7</a> * Given the JSON fields are not mandatory, this reporter simply extracts the body of the * response without validation. - * A RFC9457 message is detected by the content type "application/problem+json". + * A RFC 9457 message is detected by the content type "application/problem+json". * * @param <T> The type of the response. * @param <E> The base exception type to throw if the response is not a RFC9457 message. */ -public abstract class Rfc9457Reporter<T, E extends Exception> { - protected abstract boolean isRfc9457Message(T response); +public abstract class RFC9457Reporter<T, E extends Exception> { + private static final Gson GSON = new Gson(); Review Comment: I am OK with GSON as long as it does not leak into other components (plugins) and causes classpath issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
