[ 
https://issues.apache.org/jira/browse/MBUILDCACHE-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878104#comment-17878104
 ] 

ASF GitHub Bot commented on MBUILDCACHE-106:
--------------------------------------------

AlexanderAshitkin commented on code in PR #178:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/178#discussion_r1738618087


##########
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##########
@@ -892,6 +892,18 @@ private void restoreGeneratedSources(Artifact artifact, 
Path artifactFilePath, M
             Files.createDirectories(outputDir);
         }
         CacheUtils.unzip(artifactFilePath, outputDir);
+        OutputType outputType = 
OutputType.fromClassifier(artifact.getClassifier());
+        if (outputType != OutputType.GENERATED_SOURCE) {
+            return;
+        }
+        Path targetDir = Paths.get(project.getBuild().getDirectory());
+        if (outputDir.equals(targetDir.resolve("generated-sources"))

Review Comment:
   zzzя





> Missing compile source roots matching 'generated-sources' and 
> 'generated-test-sources' when compiler is skipped
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: MBUILDCACHE-106
>                 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-106
>             Project: Maven Build Cache Extension
>          Issue Type: Bug
>            Reporter: Réda Housni Alaoui
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to