[ 
https://issues.apache.org/jira/browse/MBUILDCACHE-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877287#comment-17877287
 ] 

ASF GitHub Bot commented on MBUILDCACHE-107:
--------------------------------------------

reda-alaoui commented on code in PR #181:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/181#discussion_r1734256032


##########
src/main/java/org/apache/maven/buildcache/DefaultNormalizedModelProvider.java:
##########
@@ -81,7 +82,7 @@ private Model normalizedModelInner(MavenProject project) {
         // does not make sense to add project version to calculate hash
         resultModel.setVersion(NORMALIZED_VERSION);
         resultModel.setModules(prototype.getModules());
-
+        
resultModel.setProperties(normalizeProperties(prototype.getProperties()));

Review Comment:
   @AlexanderAshitkin , maybe you missed the initial problem description that 
was available in https://issues.apache.org/jira/browse/MBUILDCACHE-107:
   
   > Changing a pom.xml property like `maven.build.cache.exclude.glob.1` does 
not impact the input checksum and therefore keeps using the wrong cache entry. 
The only remediation is to remove the cache entry manually.
   
   Tell me if it makes sense to you.





> pom.xml properties 'maven.build.cache.*' are not part of the effective pom 
> involved by the checksum
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MBUILDCACHE-107
>                 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-107
>             Project: Maven Build Cache Extension
>          Issue Type: Bug
>            Reporter: Réda Housni Alaoui
>            Priority: Major
>              Labels: pull-request-available
>
> Changing a pom.xml property like {{maven.build.cache.exclude.glob.1}} does 
> not impact the input checksum and therefore keeps using the wrong cache 
> entry. The only remediation is to remove the cache entry manually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to