[
https://issues.apache.org/jira/browse/MSHARED-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877151#comment-17877151
]
ASF GitHub Bot commented on MSHARED-1358:
-----------------------------------------
slawekjaranowski commented on code in PR #97:
URL: https://github.com/apache/maven-verifier/pull/97#discussion_r1733432050
##########
src/site/xdoc/download.xml.vm:
##########
@@ -23,104 +23,52 @@ under the License.
<properties>
<title>Download ${project.name} Source</title>
</properties>
+
<body>
<section name="Download ${project.name} ${project.version} Source">
- <p>${project.name} ${project.version} is distributed in source format.
Use a source archive if you intend to build
- ${project.name} yourself. Otherwise, simply use the ready-made binary
artifacts from central repository.</p>
-
- <p>You will be prompted for a mirror - if the file is not found on
yours, please be patient, as it may take 24
- hours to reach all mirrors.<p/>
+ <p><strong>${project.name} ${project.version}</strong> is distributed in
source format.</p>
- <p>In order to guard against corrupted downloads/installations, it is
highly recommended to
- <a
href="http://www.apache.org/dev/release-signing#verifying-signature";>verify the
signature</a>
- of the release bundles against the public <a
href="https://www.apache.org/dist/maven/KEYS";>KEYS</a> used by the Apache Maven
- developers.</p>
+ <p>Use a source archive if you intend to build
<strong>${project.name}</strong> yourself.</p>
- <p>${project.name} is distributed under the <a
href="http://www.apache.org/licenses/";>Apache License, version 2.0</a>.</p>
+ <p>Otherwise, simply use the ready-made binary artifacts from
<strong>central repository</strong>.</p>
- <p></p>We <b>strongly</b> encourage our users to configure a Maven
repository mirror closer to their location, please read <a
href="/guides/mini/guide-mirror-settings.html">How to Use Mirrors for
Repositories</a>.</p>
+ <p><strong>${project.name}</strong> is distributed under the <a
href="https://www.apache.org/licenses/";>Apache License, version 2.0</a>.</p>
- <a name="mirror"/>
- <subsection name="Mirror">
+ <subsection name="Files">
- <p>
- [if-any logo]
- <a href="[link]">
- <img align="right" src="[logo]" border="0"
- alt="logo"/>
- </a>
- [end]
- The currently selected mirror is
- <b>[preferred]</b>.
- If you encounter a problem with this mirror,
- please select another mirror.
- If all mirrors are failing, there are
- <i>backup</i>
- mirrors
- (at the end of the mirrors list) that should be available.
- </p>
+ <p>This is the current stable version of
<strong>${project.name}</strong>.</p>
- <form action="[location]" method="get" id="SelectMirror">
- Other mirrors:
- <select name="Preferred">
- [if-any http]
- [for http]
- <option value="[http]">[http]</option>
- [end]
- [end]
- [if-any ftp]
- [for ftp]
- <option value="[ftp]">[ftp]</option>
- [end]
- [end]
- [if-any backup]
- [for backup]
- <option value="[backup]">[backup] (backup)</option>
- [end]
- [end]
- </select>
- <input type="submit" value="Change"/>
- </form>
+ <table>
+ <thead>
+ <tr>
+ <th></th>
+ <th>Link</th>
+ <th>Checksum</th>
+ <th>Signature</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td>${project.name} ${project.version} (Source zip)</td>
+ <td><a
href="https://dlcdn.apache.org/maven/plugins/${project.artifactId}-${project.version}-source-release.zip";>${project.artifactId}-${project.version}-source-release.zip</a></td>
Review Comment:
should be `https://dlcdn.apache.org/maven/shared/`
```suggestion
<td><a
href="https://dlcdn.apache.org/maven/shared/${project.artifactId}-${project.version}-source-release.zip";>${project.artifactId}-${project.version}-source-release.zip</a></td>
```
and similar in other links
> Refresh download page
> ---------------------
>
> Key: MSHARED-1358
> URL: https://issues.apache.org/jira/browse/MSHARED-1358
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-verifier
> Reporter: Slawomir Jaranowski
> Priority: Major
> Labels: up-for-grabs
> Fix For: maven-verifier-next
>
>
> Old download page contains information about mirrors, which is not actual
> today.
> Some of links are also broken.
> Download page should be updated like in:
> https://issues.apache.org/jira/browse/MCLEAN-114
> https://issues.apache.org/jira/browse/MSHARED-1389
> We can copy src/site/xdoc/download.xml.vm from exaple changes according to
> project type, plugin or shared.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
