michael-o commented on code in PR #230:
URL: https://github.com/apache/maven-release/pull/230#discussion_r1733306541
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##########
@@ -616,16 +616,17 @@ private void rewriteArtifactVersions(
+ rawVersion);
} else {
// the expression used to define the
version of this artifact may be inherited
- // TODO needs a better error message, what
pom? what dependency?
throw new ReleaseFailureException(
- "Could not find property resolving
version expression: " + rawVersion);
+ "Could not find property resolving
version expression: " + rawVersion
+ + " for artifact " + key +
" in the project " + projectId
+ + ".");
}
}
} else {
// the expression used to define the version of
this artifact may be inherited
- // TODO needs a better error message, what pom?
what dependency?
throw new ReleaseFailureException(
- "Could not find properties resolving
version expression : " + rawVersion);
+ "Could not find properties resolving
version expression : " + rawVersion
Review Comment:
We should remove French space before the colon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
